ui5/webcomponents-react FP improvements for OOTB queries #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecurity/codeql-sap-js into knewbury01/webcomponent-react
Contributor
|
We keep the test pack at |
…ling to filter some results for out of the box xss query and improve test for it
knewbury01
changed the title
Copilot finished reviewing on behalf of
mbaluda
November 26, 2025 17:26
There was a problem hiding this comment.
Pull request overview
This PR reduces false positives in the XssThroughDom query for UI5 webcomponents-react by adding sanitizers for components that don't allow arbitrary user input. The changes introduce a comprehensive test suite demonstrating XSS patterns with various UI5 input components and excludes 14 component types that only accept predefined selections or numeric values.
Key changes:
- Added sanitizer logic to filter out false positives from UI5 webcomponents-react components that constrain user input (e.g., checkboxes, sliders, color pickers)
- Implemented API modeling for UI5 webcomponents-react using CodeQL's type tracking
- Created a comprehensive test case with 25 UI5 input components to validate the sanitizer behavior
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javascript/frameworks/ui5/lib/advanced_security/javascript_sap_ui5_all/Customizations.qll | Imports the new Sanitizers module into the customizations |
| javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5WebcomponentsReact.qll | Implements API modeling for UI5 webcomponents-react with type tracking and ref attribute handling |
| javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/Sanitizers.qll | Defines the ExcludedSource sanitizer class that filters out 14 component types that don't allow arbitrary user input |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/src/index.tsx | React app entry point for the test application |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/src/App.tsx | Test application demonstrating XSS patterns with 25 UI5 webcomponents, including both vulnerable and false positive cases |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/qlpack.yml | CodeQL pack configuration for the test |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/public/index.html | HTML template for the test application |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/package.json | NPM dependencies for the test application including UI5 webcomponents v2.15 |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/codeql-pack.lock.yml | CodeQL pack dependency lock file |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/XssThroughDom.qlref | Query reference file |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/XssThroughDom.ql | Copy of the XssThroughDom query for testing the sanitizer customizations |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/XssThroughDom.expected | Expected test results showing 11 components flagged as vulnerable while 14 are correctly filtered out |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/README.md | Documentation explaining how to trigger XSS in the test application |
| javascript/frameworks/ui5-webcomponents/test/queries/xss-input-dangerouslySetInnerHTML/.eslintrc.json | ESLint configuration for the test application |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * external/cwe/cwe-116 | ||
| */ | ||
|
|
||
| //a exact copy of - https://github.com/github/codeql/blob/main/javascript/ql/src/Security/CWE-079/XssThroughDom.ql |
There was a problem hiding this comment.
Typo: "a exact copy" should be "an exact copy"
Suggested change
| //a exact copy of - https://github.com/github/codeql/blob/main/javascript/ql/src/Security/CWE-079/XssThroughDom.ql | |
| //an exact copy of - https://github.com/github/codeql/blob/main/javascript/ql/src/Security/CWE-079/XssThroughDom.ql |
This reverts commit 881e5f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
ui5/webcomponents-reactinput types can be used for input in react apps (includes only types that have a value property)Future Works
n/a